Repository navigation
Suppress Someday marks inside the Someday view - #237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashed-border / gray-dashed treatment (Things 3 style) that flags Someday items is meaningless on the Someday page itself, where every item is a Someday item. This change introduces a small context so that subtree can opt out of the mark.
Changes
somedayMark.ts— addsSomedayMarkContext(defaults totrue) and auseSomedayMark()hook, documenting that the mark is on by default and can be disabled for subtrees where it carries no signal.TaskCheckbox— only appliesborder-dashedwhensomeday && somedayMark, so callers can turn the mark off.ProjectProgressRing— only uses the dashed outer ring / muted gray styling whensomedayMarkis enabled; behavior elsewhere is unchanged.Somedaypage — wraps the feed list inSomedayMarkContext.Provider value={false}so entries render with normal styling.Tests
TaskCheckboxtest asserting the dashed border is skipped when the context isfalse.true.Notes
No API or data changes; the flag is purely presentational and scoped to the component tree.