Repository navigation
Agent: remember per-project MCP defaults - #1159
Merged
Merged
Conversation
Contributor
|
@marksftw we reviewed this and think it's good to merge, provided you've tested it and it works from your side. If it does, go ahead and mark it ready for review. What we pushed: one docs-only commit, a404e73. It updates the README to say that tasks created over ACP also pick up a project's saved MCP choices, since they create tasks without naming servers. Possible follow-ups: none of these block this PR.
Generated by Claude Code |
ACP sessions create tasks without naming servers, so their account servers follow the Settings switches with the project's saved choices applied. Say so in the custom MCP and ACP sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GkZQmZL1DVpBz28aefPoaw
AnthonyRonning
force-pushed
the
codex-agent-1156-maple
branch
from
October 16, 2026 19:06
a404e73 to
df9ee3b
Compare
AnthonyRonning
marked this pull request as ready for review
October 16, 2026 19:42
AnthonyRonning
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New-task custom MCP switches now save per-project defaults. Each server follows the global Settings switch until explicitly changed in that project. Sending the first message snapshots the displayed choices; toggling a server in an existing task affects only that task.
Project choices use an account-scoped, device-local sidecar keyed by canonical folder and server identity. Switching projects reloads those choices while preserving the unsent draft, and Off servers remain available in the menu. Server definitions remain in the global Settings catalog.
Fixes #1156.
Shared-host integration
Rebased onto
22611507, including the shared desktop/ACP host from #1161. Desktop reads and writes project defaults through typed host operations, using the existing account checks and settings lock. New desktop and ACP tasks inherit the same defaults; loading an existing task preserves its own selections.Host recovery reloads a draft's project defaults and retains unsent text and local choices. If the connection drops while first send is waiting for those defaults, the UI clears the pending send and asks the user to send again after reconnecting. It does not replay a prompt automatically.
Validation
just cithroughMAPLE_HOOK_FULL=1pre-commit passed on macOS: formatting, all four Clippy configurations, workspace build/tests, and headless ACP/proxy tests. Includes 271 runtime tests (2 ignored), 464 desktop tests, and 68 headless tests.These checks use isolated local fixtures and a scripted model. Authenticated live inference and a new Paseo smoke were not run. Hosted platform and packaging checks are pending for the pushed head.
Need help on this PR? Tag
@codesmith-botwith what you need.