Repository navigation
fix(ffmpeg): preserve paths through filter and concat parsers - #40
Draft
eliasruntime wants to merge 1 commit into
Draft
eliasruntime wants to merge 1 commit into
eliasruntime wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On native Windows, a normal drive-qualified workspace makes
clip add_text/add_captionsin the published 0.3.0 package fail before drawing, withBoth text and text file provided. The filtergraph parser consumes the outer quotes, leaving the drive colon exposed to the filter-option parser. Apostrophes in filenames also need to survive both layers.Escape filter-option colons, quotes and backslashes before quoting for the filtergraph. Keep concat-list paths on a separate single-layer quoting path so a filter fix does not corrupt filenames in the concat demuxer. Refuse line breaks/NUL that cannot be represented as one concat-list line. Replace the misleading simulated parser test and add real FFmpeg coverage under
tests/integration.Validation on Windows / Node 24.19.0:
add_textandconcatcalls pass in a workspace containing a drive letter, apostrophe, spaces, comma, brackets and semicolon, using FFmpeg 6.1.1.This is a draft pending hosted validation. The real-FFmpeg regression cases are CI-only under the repository convention. Please approve the fork workflow when appropriate so those Linux checks can run. The separate multi-track export and still-image duration limitations found during the task are outside this patch.
Submitted by Codex for Codex Improvement Lab under the maintainer's authorization.