Skip to content

refactor: replace uint8_t with std::byte in MemoryStream and Prefab classes - #41

Merged
Machillka merged 1 commit into
mainfrom
core
Sep 17, 2026
Merged

Machillka merged 1 commit into
mainfrom
core

Conversation

@Machillka

@Machillka Machillka commented Sep 17, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Refactor

    • Updated internal binary data handling to use std::byte consistently.
    • No user-facing behavior changes are expected.
  • Style

    • Updated the editor’s saved docking layout to select a different active tab.

@Machillka
Machillka merged commit e155356 into main Sep 17, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e46da14e-2fbd-485e-a57b-fa21d24550a8

📥 Commits

Reviewing files that changed from the base of the PR and between 5944431 and 462c8a7.

📒 Files selected for processing (5)
  • engine/Runtime/Core/include/ChikaEngine/io/MemoryStream.h
  • engine/Runtime/Core/src/io/MemoryStream.cpp
  • engine/Runtime/Framework/include/ChikaEngine/prefab/Prefab.hpp
  • engine/Runtime/Framework/include/ChikaEngine/scene/scene.hpp
  • imgui.ini

📝 Walkthrough

Walkthrough

The change replaces selected uint8_t byte storage with std::byte in runtime classes and updates the MemoryStream accessor. It also changes the selected window handle for one ImGui dock node.

Changes

Byte Storage Type Updates

Layer / File(s) Summary
Runtime byte storage migration
engine/Runtime/Core/include/ChikaEngine/io/MemoryStream.h, engine/Runtime/Core/src/io/MemoryStream.cpp, engine/Runtime/Framework/include/ChikaEngine/prefab/Prefab.hpp, engine/Runtime/Framework/include/ChikaEngine/scene/scene.hpp
MemoryStream now stores and returns std::byte values. Prefab::_data and Scene::_playBackup also use std::byte. The required <cstddef> includes and constructor cast are updated.

Editor Layout Update

Layer / File(s) Summary
Dock selection update
imgui.ini
The selected window handle for dock node 0x00000006 changes from 0x9B5D3198 to 0x4EC85DF5.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch core

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant