Fix UI layout issues and improve accessibility - #67
Open
maurizio-bruccoleri wants to merge 2 commits into
Open
Conversation
- Redesigned settings interface with unified scrollable layout - Fixed hidden controls in Advanced section (Delete buttons now accessible) - Improved section titles visibility (Interface/Advanced) - Optimized spacing and layout constraints for better MacPass integration - All controls now properly visible and accessible via scroll - Version bump to 0.3.3 Fixes: Controls in Advanced section were cut off and inaccessible Resolves: Layout inconsistencies with MacPass preferences interface
- Changed CFBundleVersion from hardcoded 'UNKNOWN' to $(CURRENT_PROJECT_VERSION) - Plugin now shows proper version number instead of 'Version: X.X.X (UNKNOWN)' - Maintains compatibility with existing Versioning script for git commit counting Fixes: Version display showing '(UNKNOWN)' instead of build number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: UI Layout Fixes and Improve Accessibility
Summary
This PR addresses critical UI layout issues and fixes version display problems in the MacPassHTTP plugin.
Problems Solved
The MacPassHTTP plugin had significant UI/UX issues:
Solutions Implemented
UI/UX Improvements
Version Display Fix
CFBundleVersionfrom hardcoded 'UNKNOWN' to$(CURRENT_PROJECT_VERSION)Technical Changes
MacPassHTTPSettings.xibwith modern AutoLayout constraintsVersion Update
Before/After Comparison
Before
After
Testing
Files Modified
MacPassHTTP/Base.lproj/MacPassHTTPSettings.xib- Complete UI redesignMacPassHTTP.xcodeproj/project.pbxproj- Version updateMacPassHTTP/Info.plist- Version display fixBackward Compatibility
Type: Bug Fix, Enhancement
Priority: High (affects core plugin usability)
Breaking Changes: None
Testing Required: UI/UX verification in MacPass