fix GMCP error caused by forwarding External.Discord.Get to MUME

[nschimme]

Handle External.Discord.Get messages locally to avoid MUME GMCP errors.

Bug Fixes:

• Prevent unsupported External.Discord.Get messages from being forwarded to MUME and triggering GMCP protocol errors.

Enhancements:

• Register External.Discord.Get as a recognized GMCP message type.

Tests:

• Add coverage for deserializing and identifying External.Discord.Get messages.

Summary by Sourcery

Prevent External.Discord.Get messages from reaching MUME and causing GMCP errors.

Bug Fixes:

• Handle External.Discord.Get messages locally instead of forwarding them to MUME, preventing GMCP protocol errors.

Enhancements:

• Recognize External.Discord.Get as a supported GMCP message type.

Tests:

• Add coverage for deserializing and identifying External.Discord.Get messages.

[sourcery-ai]

Sorry @nschimme, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 20 hours and 20 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The proxy now registers and identifies External.Discord.Get messages, then consumes them locally so unsupported requests are not forwarded to MUME and cannot trigger GMCP protocol errors. Tests cover deserialization, message naming, and type recognition.

Sequence diagram for local handling of External.Discord.Get

sequenceDiagram
    participant Client
    participant UserTelnet
    participant MUME

    Client->>UserTelnet: External.Discord.Get
    UserTelnet->>UserTelnet: isExternalDiscordGet()
    UserTelnet-->>Client: Consume message locally
    Note over UserTelnet,MUME: Message is not forwarded to MUME

Loading

File-Level Changes

Change	Details	Files
Recognize External.Discord.Get as a first-class GMCP message type.	Added the message to the centralized type registry and generated enum/count metadata. Added deserialization and type-identification test coverage.	src/proxy/GmcpMessage.h tests/TestProxy.cpp
Consume External.Discord.Get locally instead of forwarding it to MUME.	Added an early-return handler in the user Telnet GMCP receive path to suppress the unsupported message before forwarding.	src/proxy/UserTelnet.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.28%. Comparing base (1e3eafb) to head (f5245d8).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
+ Coverage   25.08%   27.28%   +2.19%     
==========================================
  Files         528      559      +31     
  Lines       44211    45915    +1704     
  Branches     4793     4879      +86     
==========================================
+ Hits        11092    12527    +1435     
- Misses      33119    33388     +269     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sourcery-ai]

Sourcery assessment

Approved.

[sourcery-ai]

Sourcery assessment

Approved.

[sourcery-ai]

Sourcery assessment

Approved.