Skip to content

Problematic protein identification with viewer.expandAndCollapseSelection(proteinIdentifier) #160

Open

Description

@EliotRagueneau

Currently, viewer.expandAndCollapseSelection(proteinIdentifier) uses the UniProt id to collapse or expand the proteins, but this is problematic on cases such as this one on intact-portal because both participants have the same identifier, but they are not the same participants.

Would there be a way to use IntAct participant's ac for this function instead, to avoid this problem? Or maybe se should add another parameter indicating which field complex viewer should be looking for among the participants to collapse/expand them? e.g. viewer.expandAndCollapseSelection(id, idType)

P.S.: I'm relatevily new to IntAct team, and began recently to work a bit on complex viewer, but you've done a really good job here @colin-combe, it's a really nice viewer. Thanks a lot for your help and support!

Activity

  1. self-assigned this
    on Nov 25, 2020
  2. colin-combe commented on Nov 25, 2020

    @colin-combe

    viewer.expandAndCollapseSelection(id, idType)

    yes, we can do that

  3. colin-combe commented on Jan 7, 2021

    @colin-combe

    @EliotRagueneau - hmm, I don't think I can find this Intact participant ac in the json the viewer recieves.
    To see the json, I'm looking here: https://wwwdev.ebi.ac.uk/intact/ws/graph/interaction/export/EBI-7156290
    It may need a change to the json? (or do you see it in there somewhwhere?)

  4. EliotRagueneau commented on Jan 7, 2021

    @EliotRagueneau
    Author

    You are absolutely right, we'll have to fix this! @noedelta maybe you could do that since you're currently working on the Complex Viewer?

  5. colin-combe commented on Feb 25, 2021

    @colin-combe

    i'll unassign myself since it can't be done until Intact participant ac is in the json

  6. removed their assignment
    on Feb 25, 2021
  7. colin-combe commented on Jul 19, 2021

    @colin-combe

    from meeting, plan is for @noedelta to add Intact participant ac to the json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions