Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Empty subgroup headers must be normalized to preserve the default set label.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Standardizes set-header parsing across match-group inputs and custom wiki parsers.
Changes:
- Adds shared set-header parsing.
- Migrates Warcraft, Stormgate, Hearthstone, and StarCraft handling.
- Preserves game-specific header mappings.
File summaries
| File | Description |
|---|---|
lua/wikis/warcraft/MatchGroup/Input/Custom.lua |
Uses standardized subgroup headers. |
lua/wikis/stormgate/MatchGroup/Input/Custom.lua |
Uses standardized subgroup headers. |
lua/wikis/hearthstone/MatchGroup/Input/Custom.lua |
Uses standardized subgroup headers. |
lua/wikis/commons/MatchGroup/Input/Util.lua |
Adds shared header parsing. |
lua/wikis/commons/MatchGroup/Input/Starcraft.lua |
Uses shared submatch-header parsing. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hjpalpha
reviewed
Sep 17, 2026
| return Table.map(setHeaders, function(key, value) | ||
| return 'subgroup' .. (key:sub(#prefix + 1)), value | ||
| end) | ||
| end |
Collaborator
There was a problem hiding this comment.
maybe we should write this in a way that it allows the bot jobs without breaking stuff?
(and after the bot jobs change it to this)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have standardized support of set parsing and display, but not of custom set headers. This PR implements this.
How did you test this change?
dev on chess and sc2