Conversation
Rathoz
added this pull request to stack #8098
September 16, 2026 12:04
mbergen
reviewed
Sep 16, 2026
Collaborator
There was a problem hiding this comment.
Our spec folder is quite large, would it make sense to all sort into multiple sub folders? spec/domain/bracket_spec.lua for example.
Resolves a conflict in MatchGroup/Util/Types.lua, where upstream edited two annotations in place while this branch moved them into the domain layer. Both upstream additions are carried into Domain/Match/Model.lua: - standardPlayer gained `roles string[]?` - MatchGroupUtilMatch gained `submatches MatchGroupUtilSubgroup[]` Also repoints two references the earlier moves missed, because neither is an import: the perf profiling list in Bracket/Template.lua, and stale module paths in the MatchGroup/Util header comment. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP
How did you test this change