refactor: overhaul notability checker display - #8089
ElectricalBoy wants to merge 9 commits into
Conversation
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
fwiw i still think that the entire notability checker setup could eventually use a clean rewrite that actually supports all wikis
| for _, person in pairs(people) do | ||
| local personWeight = NotabilityChecker._calculatePersonNotability(person) | ||
| output = output .. mw.getCurrentFrame():expandTemplate{ | ||
| title = 'NotabilityPlayerMatchesTable', args = {title = person}} |
There was a problem hiding this comment.
fwiw this might exist on some wikis with overwriting the normal results table
There was a problem hiding this comment.
I would argue that the local overrides should be added to /Custom
plus imo having this unnecessary template expansion is just more evil
There was a problem hiding this comment.
tend to agree
but you will likely get pushback from some of the affected wikis
There was a problem hiding this comment.
I know at least some wikis have versions of it that displays the score per result, which i doubt they want to lose. Could add that to ResultsTable/Base i guess.
3 participants
Summary
This PR:
How did you test this change?
untested