feat: Add GameHistory to GitHub - #8088
steve020607 wants to merge 4 commits into
Conversation
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
this barely uses GameTable
why is it building a display itself instead of utilizing GameTable properly?
| local inputs = self:_readOpponentInputsFromBase(base) | ||
|
|
||
| if Logic.isEmpty(inputs) then | ||
| assert(self.title.namespace == 0, 'Required ' .. base .. '= argument') |
There was a problem hiding this comment.
don't remove this assert
you need to bypass this case entirely for your purposes
the table insert below it is wrong for your case too
There was a problem hiding this comment.
I remember this, if i remove it, it turn to an error if |team= are not inputed
There was a problem hiding this comment.
yeah, but inserting basepagename as team is wrong for your case too, hence the remark that you have to bypass the entire if block for your case
There was a problem hiding this comment.
So what is the fix for this?
So of it are override the GameTable since to fix some of the issue that GameTable didn't had Or you mean by importing it to the GameTable and use it there? |
2 participants
Summary
This PR is changing the local wiki Game history to the Standardized GameHistory
This Code is developed by Claude and me
How did you test this change?
dev