Skip to content

chore: remove seriesnumber on placement level - #8083

Closed
hjpalpha wants to merge 2 commits into
refactor-series-medal-stats-to-featurefrom
remove-seriesnumber-on-placement-level
Closed

chore: remove seriesnumber on placement level#8083
hjpalpha wants to merge 2 commits into
refactor-series-medal-stats-to-featurefrom
remove-seriesnumber-on-placement-level

Conversation

@hjpalpha

@hjpalpha hjpalpha commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

stacked on #8082

resolves #7890

Summary

as title says

How did you test this change?

untested, just removing stuff

@hjpalpha
hjpalpha added this pull request to stack #8084 September 12, 2026 15:40
@hjpalpha hjpalpha linked an issue Sep 12, 2026 that may be closed by this pull request
eliminate seriesnumber on lpdb_placement.extradata level #7890
Open
8 tasks
@hjpalpha
hjpalpha marked this pull request as ready for review September 13, 2026 07:24
@hjpalpha
hjpalpha requested review from a team as code owners September 13, 2026 07:24
mbergen
mbergen approved these changes Sep 15, 2026
View reviewed changes

@mbergen mbergen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy when the *craft wikis come a little bit closer to standard processing :)

@hjpalpha

hjpalpha commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

Always happy when the *craft wikis come a little bit closer to standard processing :)

it took me months to convert all the stuff for it ...

hjpalpha added a commit that referenced this pull request Sep 18, 2026
@hjpalpha
merge wc parts into sc, fix typo, kick seriesnumber (see #8083 too)
85b198d
hjpalpha added a commit that referenced this pull request Sep 18, 2026
@hjpalpha
merge wc parts into sc, fix typo, kick seriesnumber (see #8083 too)
1626752
Rathoz pushed a commit that referenced this pull request Sep 18, 2026
@hjpalpha
refactor(participantTable): merge wc and sg customs into sc/sc2 "cust…
1cd296e 
…om" (#8111)

* stormgate is code wise identical, so just can use sc

* merge wc parts into sc, fix typo, kick seriesnumber (see #8083 too)
@hjpalpha hjpalpha mentioned this pull request Sep 18, 2026
Merged
@hjpalpha hjpalpha closed this Sep 18, 2026
@hjpalpha
hjpalpha deleted the remove-seriesnumber-on-placement-level branch September 18, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElectricalBoy ElectricalBoy ElectricalBoy approved these changes
@mbergen mbergen mbergen approved these changes

Assignees

No one assigned

Labels

c: participant_table c: prize_pool g: broodwar Starcraft: Brood War g: starcraft Starcraft g: stormgate Stormgate g: warcraft Warcraft

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eliminate seriesnumber on lpdb_placement.extradata level

3 participants

@hjpalpha @ElectricalBoy @mbergen