refactor: bulletproof step 1.M

[Rathoz]

Summary

Split one of the massive of Match2 modules (MatchGroup/Util) into a few smaller ones along bracket/domain split.

The domainification will contain additional splitting.

The tests are temporary to help with migration. Let's make new tests in the end that tests intended functioanlity, rather than what the code correctly does..

How did you test this change?

tested on LoL bracket, matchlist and matchpage.

[Copilot]

🟡 Changes recommended

Resolve the headerless-root crash and incorrect inexact-match classification.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Refactors Match2 into focused match, bracket, input, display, and type modules while preserving compatibility exports.

Changes:

• Extracts domain-specific utilities and model types.
• Updates wiki consumers to use shared input helpers.
• Adds unit coverage for refactored behavior.

File summaries

File	Reviewed change
lua/wikis/valorant/MatchGroup/Input/Custom.lua	Uses shared input helpers.
lua/wikis/leagueoflegends/MatchGroup/Input/Custom.lua	Uses shared input helpers.
lua/wikis/dota2/MatchGroup/Input/Custom.lua	Uses shared input helpers.
lua/wikis/commons/MatchGroup/Util/Types.lua	Defines shared model types.
lua/wikis/commons/MatchGroup/Util/Starcraft.lua	Adapts StarCraft parsing.
lua/wikis/commons/MatchGroup/Util/Match.lua	Extracts match conversion logic; date classification requires correction.
lua/wikis/commons/MatchGroup/Util/Bracket.lua	Extracts bracket logic.
lua/wikis/commons/MatchGroup/Util.lua	Preserves aggregate utilities and exports.
lua/wikis/commons/MatchGroup/Input/Util.lua	Adds input normalization helpers.
lua/wikis/commons/MatchGroup/Input.lua	Uses input normalization.
lua/wikis/commons/MatchGroup/Display/Helper.lua	Handles bracket-reset merging.
lua/wikis/commons/MatchGroup/Display/Bracket.lua	Uses display merging helpers.
lua/wikis/commons/MatchGroup/Coordinates.lua	Headerless roots still cause a crash.
lua/wikis/commons/Match.lua	Uses input normalization.
lua/spec/match_group_util_spec.lua	Tests utility assembly and exports.
lua/spec/match_group_util_match_spec.lua	Tests match model behavior.
lua/spec/match_group_util_bracket_spec.lua	Tests bracket behavior.
lua/spec/match_group_input_util_spec.lua	Tests input helpers.
lua/spec/match_group_display_helper_spec.lua	Tests display merging.

Review details

Suppressed comments (1)

lua/wikis/commons/MatchGroup/Util/Match.lua:246

• This preserves a real classification bug: matchFromRecord converts dateexact = '0' into dateIsExact = false, but match.dateIsExact or match.dateexact discards that explicit false, so a past inexact match is reported as ongoing. Select dateIsExact when it is non-nil (including false) and update the new regression test to expect upcoming for the model path.

	-- TODO: a dateIsExact of false becomes nil here, so it is treated as unknown rather than as
	-- inexact, and a past match with dateIsExact = false reads as ongoing instead of upcoming.
	-- Only the record spelling (dateexact = '0') currently makes a match inexact.
	local isExact = Logic.readBoolOrNil(match.dateIsExact or match.dateexact)

• Files reviewed: 19/19 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[hjpalpha]

seems okay on phone

[ElectricalBoy]

seems reasonable for the most part