fix(intrade-bar): follow opaque legacy login redirects - #168
Merged
Merged
Conversation
Support the legacy broker login response that returns a JavaScript redirect with a one-time auth token. Follow the redirect, merge issued cookies, preserve the existing id/hash parser, and keep the selected redirect origin for subsequent authentication requests. Add parser and local HTTP regression coverage.
LimiNode
force-pushed
the
fix/intrade-opaque-login
branch
from
September 14, 2026 16:58
9d6e46d to
2e244cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.location.replace(...)with an opaque/auth/<token>URL;Set-Cookievalues, and keep the broker-selected origin for the subsequent/authrequest;intrade.bar/intrade<N>.barallowlist and fail closed before forwarding login cookies elsewhere;id/hashlogin format, including absolute legacy redirects, and add parser plus local HTTP regression coverage.Verification
intrade_bar_api_response_test.exe— 93 tests passed;auth-cachethrough the updated proxy — fresh and cached authentication passed;quotes --symbol=EURUSD— quote snapshot returned successfully;show-accountand CSV history smoke checks passed without trade requests.The new
trading.intrade.barbroker/API is intentionally out of scope and will be implemented as a separate platform.