[CHANGE] Reuse the same request session on same instance

[pablo-estevez-lrn]

• Reuse the same request session on the same Data API instance
• Added a close() public method to close the session

Checklist

• Feature

• Bug

• Security

• Documentation

• ChangeLog.md updated

• Tests added

• All testsuites passed

• make dist completed successfully

• Bump package version if release coming

[Copilot]

🟡 Changes recommended

Session cleanup needs a deterministic public API, and the reuse behavior lacks regression coverage.

3 open findings

• Expose deterministic client cleanup via public close() · New
• Add missing article “the” to changelog entry · New
• Test session reuse across multiple requests · New

What changed in this PR

Reuses one HTTP session per DataApi instance to enable connection pooling.

Changes:

• Adds session creation and cleanup.
• Routes requests through the shared session.
• Updates the changelog.

File	Description
learnosity_sdk/​request/​dataapi.py	Introduces and uses a shared request session.
ChangeLog.md	Records session reuse.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

Core behavior is correctly tested; only a minor public-API documentation clarification remains.

1 open finding

• Document close() lifecycle and post-close request behavior · New

3 resolved since last review

• Expose deterministic client cleanup via public close()
• Test session reuse across multiple requests
• Add missing article “the” to changelog entry

🧠 Review effort: Balanced

[michael-linnane-lrn]

Hey @pablo-estevez-lrn, two comments. We need to be careful when altering existing classes since we don't know how the integrations might be used already. Should be easy to fix with backwards compatibility though

[michael-linnane-lrn]

❓ Question: Why allow later requests? Would we not just fully drop it and have an actual blank slate?

Suggested change

	session = getattr(self, '_session', None)
	if session is not None:
	session.close()
	if getattr(self, '_session', None) is not None:
	self._session.close()
	self._session = None

[pablo-estevez-lrn]

2 reasons:

1. To avoid an invalid state after close(), when we raise an error None does not have an attribute post. (after the last commit, will be creating a new session instead)
2. To use the same known semantic that requests, where close is closing the transport, but not converting to a blank slate.
   If you want to destroy the object, you can always use del()

it will be functionally equivalent, so happy to change if you want

[michael-linnane-lrn]

❗️ Pressing: Adding __init__ here makes super().__init__() mandatory for subclasses. DataApi previously inherited object.__init__, and since we could have customers that don't have a version pinned and did the above we would actually break their integration. We might need to make it Optional

[pablo-estevez-lrn]

Fair point, if _session is not an attr when we try to do the request, we can create the request. Fixed on f2b5117