docs(openapi): add job-change-detector statuses and resolution_reason - #27
Merged
Conversation
Sync the Job Change Detector snapshot with the live API contract: - status enum gains AMBIGUOUS_CURRENT_EMPLOYMENT, CURRENT_EMPLOYMENT_UNKNOWN (matched employer, undated role — unknown, not a change) and PROFILE_NOT_FOUND (profile URL did not resolve — credits_consumed is 0) - add the resolution_reason enum - document that job_change_detected is true only for JOB_CHANGE_DETECTED and that an absent expected employer with another primary current role is JOB_CHANGE_DETECTED (NEVER_WORKED_THERE only when nothing is current) - credits_consumed example corrected from 2 to 3 YAML and JSON stay in sync (deep-equal verified).
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the Job Change Detector (
POST /v1/people/job-change-detector) snapshot with the live API contract shipped by LeadMagic/lm-workers#522:statusenum now listsAMBIGUOUS_CURRENT_EMPLOYMENT,CURRENT_EMPLOYMENT_UNKNOWN(expected employer matched but the role carries no dates — unknown, not a change) andPROFILE_NOT_FOUND(profile URL did not resolve —credits_consumedis0, nothing is charged)resolution_reasonenum (incl.PROFILE_NOT_FOUND)job_change_detectedistrueonly whenstatusisJOB_CHANGE_DETECTED, and that an absent expected employer with another primary current role isJOB_CHANGE_DETECTED(NEVER_WORKED_THEREonly when nothing is current)credits_consumedexample corrected from2to3leadmagic-openapi-3.1.yamland.jsonwere deep-equal verified after the edit. No generator exists forllms.txt, so it is untouched.Test plan
npm run lint:openapi— 0 errors (22 pre-existing unused-component warnings)npm run typecheck🤖 Generated with Claude Code