GH Issue 1477: Enforce required comments for sample type import template updates - #8006
Open
labkey-susanh wants to merge 2 commits into
Open
GH Issue 1477: Enforce required comments for sample type import template updates#8006labkey-susanh wants to merge 2 commits into
labkey-susanh wants to merge 2 commits into
Conversation
XingY
reviewed
Sep 1, 2026
|
|
||
| if (getUser().isGuest()) | ||
| { | ||
| // Guests can only delete |
Contributor
There was a problem hiding this comment.
Perhaps the check of appHome should move to Container.getAuditCommentsRequired? Also in getAuditCommentsRequired, props initialization should be moved to after ProductFeature.DataChangeCommentRequirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1477
Related Pull Requests
Changes
UpdateQueryImportTemplateActionfor user comment.