GitHub Issue 1499: SpecialCharacterMetricsMaintenanceTask is throwing exceptions on legacy specimen tables - #8005
Open
XingY wants to merge 1 commit into
Open
GitHub Issue 1499: SpecialCharacterMetricsMaintenanceTask is throwing exceptions on legacy specimen tables#8005XingY wants to merge 1 commit into
XingY wants to merge 1 commit into
Conversation
… exceptions on legacy specimen tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Prior to https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=29047, when a domain field name matches domain base field name, the storagecolumnname for that field has a numeric suffix added to it. Specimen tables has provisioned table sharing columns with base fields, including rowId, Container, etc. The legacy specimen has exp.propertydescriptor.storagecolumnname as
Container1for container fields, while the actual provisioned table's column name isContainer. This mismatch is causing SpecialCharacterMetricsMaintenanceTask to throw bad SQL exception due to unknown column in select.Related Pull Requests
Changes
allowAddBasePropertyparam