Cleanup: Remove stale docs and duplicate docker-compose files - #53
Draft
mohit-nagaraj wants to merge 1 commit into
Draft
mohit-nagaraj wants to merge 1 commit into
mohit-nagaraj wants to merge 1 commit into
Conversation
- Delete docs/idea.md (superseded by docs/ARCHITECTURE.md) - Delete docs/npm-publishing.md (superseded by PUBLISHING.md and AUTOMATED-RELEASE.md) - Delete duplicate /docker/*.yml files (kept /cmd/docker/*.yml as source) - Update runtime_contract_test.go to reference embedded compose files correctly Co-authored-by: Mohit Nagaraj <me@mohitnagaraj.in>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed stale/redundant documentation and duplicate docker-compose copies from the repository.
Changes
Deleted Files
docs/idea.md- Early brainstorming document superseded bydocs/ARCHITECTURE.mddocs/npm-publishing.md- Detailed publishing guide superseded bydocs/PUBLISHING.mdanddocs/AUTOMATED-RELEASE.mddocker/docker-compose.dev.yml- Duplicate ofcmd/docker/docker-compose.dev.ymldocker/docker-compose.prod.yml- Duplicate ofcmd/docker/docker-compose.prod.ymldocker/docker-compose.hybrid-ui.yml- Duplicate ofcmd/docker/docker-compose.hybrid-ui.ymldocker/docker-compose.hybrid-core.yml- Duplicate ofcmd/docker/docker-compose.hybrid-core.ymlUpdated Files
cmd/runtime_contract_test.go- Updated file path reference for embedded compose file comparisonVerification
go build ./...passesgo test ./cmd/...passescmd/docker/Impact
/docker/were exact duplicates of those in/cmd/docker/