fix(search): open cmd+K with the cursor in the search box - #1
Closed
Jonathan-Asher wants to merge 1 commit into
Closed
Jonathan-Asher wants to merge 1 commit into
Jonathan-Asher wants to merge 1 commit into
Conversation
The dialog's first focusable element is the Conversations tab button, so that is where Radix put focus when the dialog opened: typing right after cmd+K went nowhere until the search box was clicked. Clicking a tab moved focus onto the tab as well. The search box now takes focus when the dialog opens and keeps it when switching tabs (the tab buttons no longer take focus on mouse down).
Owner
Author
|
Opened upstream as xintaofei#833. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI check of the upstream PR branch against upstream main (mirrored here as
upstream-main).