fix(agentcore-demo): run on any cluster name; own Forge target per cluster - #68
Merged
Merged
Conversation
…uster
- gateway-deployment.yaml takes the CA ClusterIssuer from state
({{.BNK_CA_ISSUER}}) instead of the Sydney cluster's name, so the TLS
certificate issues on a cluster with another name
- the scripts use the Gateway name the manifests fix
(bnk-agentcore-demo-gateway) instead of <cluster>-gateway
- rebuild.sh merges this cluster's OIDC provider into the shipper role's
trust policy and keeps the other live clusters' statements
- forge target registration: when Forge already holds the target name for
another cluster (names are global in Forge), register this cluster's
endpoint as <name>-<cluster> instead of silently reusing the other
cluster's target
Verified on agent-core-singapore: certificate Ready with the rendered
issuer; forge scan --register-targets created target 7
mcp-default-mcp-financial-route-agent-core-singapore on cluster 21 where
it previously returned Sydney's target 5.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gateway-deployment.yamltakes the CA ClusterIssuer from state ({{.BNK_CA_ISSUER}}) instead of the Sydney cluster's issuer name, so the TLS certificate issues on a cluster with any name.rebuild.sh,demo.shandsetup-agentcore-network.shuse the Gateway name the manifests fix (bnk-agentcore-demo-gateway) instead of<cluster>-gateway.rebuild.shmerges the cluster's OIDC provider intoBNKDemoBedrockTokenShipper's trust policy and keeps the statements of other live clusters, so several demo clusters share the role.<name>-<cluster>instead of silently reusing the other cluster's target.Verified
agent-core-singapore (ap-southeast-1):
k apply --configrendersagent-core-singapore-ca-cluster-issuer, certificate Ready;forge scan --register-targetscreated target 7mcp-default-mcp-financial-route-agent-core-singaporeon cluster 21, where it previously returned Sydney's target 5. Trust-merge snippet checked in a python:3.11 container (stale provider dropped, live one kept, new one added).🤖 Generated with Claude Code