ci: harden GitHub Actions workflows and add zizmor scan - #375
Merged
Conversation
Backport of IntelPython/dpctl#2374, adapted to mkl_fft's workflows: - add a zizmor CI job that audits the workflow files under .github/ - add persist-credentials: false to every actions/checkout step that lacked it - narrow top-level permissions: read-all to permissions: contents: read - add a 7-day cooldown to the dependabot update entries
antonwolfy
requested review from
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
September 3, 2026 10:39
vlad-perevezentsev
approved these changes
Sep 3, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of IntelPython/dpctl#2374, adapted to mkl_fft's own set of workflows.
Adds a CI job that runs the zizmor static analyzer over the workflow files under
.github/.zizmoraudits GitHub Actions workflows for supply-chain and privilege-escalation weaknesses — credential persistence through the checkout token, overly broadGITHUB_TOKENpermissions, unpinned action references, and template injection via${{ ... }}expansion inrun:blocks.Alongside the new scan, this applies the corresponding hardening to the existing workflows so they pass the audit:
persist-credentials: falseto everyactions/checkoutstep that lacked itpermissions: read-alltopermissions: contents: readcooldownto the dependabot update entriesThe dpctl-only changes do not apply here: mkl_fft has no
backfill-docs.yml(nor any other${{ github.event.inputs.* }}used inside arun:block), and it does not usemshick/add-pr-comment, so the malformed version-pin fix is not relevant.This is a CI/configuration-only change; no library code, tests, or documentation are affected.