Repository navigation
fix(i18n): etiqueta de send_email y fecha de vencimiento del enlace en formato medio - #80
Merged
Merged
Conversation
…n formato medio Los dos hallazgos pequenos que dejo el recorrido en ingles de la app: - La accion `send_email` de un workflow salia con su codigo porque `workflows:actionType` solo tenia `log`. Se agrega la etiqueta (es: «enviar correo», en: «send email»). - El vencimiento del enlace del portal (`QuoteDetail`, `PortalBuilder`) usaba la fecha numerica corta (`10/12/2026`), ambigua en ingles. Pasa a formato `medium` (`10 dic 2026`). Tests: `english-workflows.test.tsx` comprueba que se vea «send email» y no el codigo; los dos tests de `PortalBuilder` esperan ahora la fecha `medium`. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
La politica de gobernanza exige tocar IMPLEMENTATION_ALIGNMENT.md cuando cambia una pagina (QuoteDetail, PortalBuilder). Se anota la regla de la fecha de vencimiento. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Los dos hallazgos pequeños que dejó el recorrido en inglés de la app.
Cambios
send_emailsin etiqueta: la acción de un workflow salía con su código porqueworkflows:actionTypesolo teníalog. Se agrega la etiqueta (es: «enviar correo», en: «send email»).QuoteDetailyPortalBuilderusaban la fecha numérica corta (10/12/2026), ambigua en inglés. Pasa a formatomedium(10 dic 2026).Verificación
english-workflows.test.tsx(nuevo test): se ve «send email» y nosend_email.PortalBuilderesperan ahora la fechamedium.Con esto se cierran los tres hallazgos del recorrido; quedan Discovery y repetir el recorrido con navegador.
🤖 Generated with Claude Code