Skip to content

updating Geckoview breaking changes #53

Description

@khelkun

Just to let one knows that there are breaking changes starting from version 105.0.20220912145803 of geckoview which prevent GeckoViewPlugn to compile:

> Task :app:compileDebugJavaWithJavac FAILED
G:\VIZUA\github\vizua3d\UnityOculusAndroidVRBrowser\GeckoViewPlugin\app\src\main\java\com\eyeflite\ian\geckoviewplugin\GeckoViewPLugin.java:728: error: method does not override or implement a method from a supertype
    @Override
    ^
G:\VIZUA\github\vizua3d\UnityOculusAndroidVRBrowser\GeckoViewPlugin\app\src\main\java\com\eyeflite\ian\geckoviewplugin\OVRSurfaceGeckoView.java:67: error: method surfaceChanged in class GeckoDisplay cannot be applied to given types;
                mDisplay.surfaceChanged(mSurface, mWidth, mHeight);
                        ^
  required: SurfaceInfo
  found: Surface,int,int
  reason: actual and formal argument lists differ in length
G:\VIZUA\github\vizua3d\UnityOculusAndroidVRBrowser\GeckoViewPlugin\app\src\main\java\com\eyeflite\ian\geckoviewplugin\OVRSurfaceGeckoView.java:117: error: method surfaceChanged in class GeckoDisplay cannot be applied to given types;
                mDisplay.surfaceChanged(mSurface, width, height);
                        ^
  required: SurfaceInfo
  found: Surface,int,int
  reason: actual and formal argument lists differ in length
G:\VIZUA\github\vizua3d\UnityOculusAndroidVRBrowser\GeckoViewPlugin\app\src\main\java\com\eyeflite\ian\geckoviewplugin\OVRSurfaceGeckoView.java:136: error: method surfaceChanged in class GeckoDisplay cannot be applied to given types;
                mDisplay.surfaceChanged(holder.getSurface(), width, height);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions