Repository navigation
Close HDF5 handles eagerly when reading and writing MPS and MPO - #225
Merged
Merged
Conversation
The HDF5 readers and writers left group and attribute handles open until garbage collection, so repeated reads got slower and slower (https://itensor.discourse.group/t/2639). They are now closed on return. The leaks inside each site tensor are fixed in ITensor/ITensors.jl#1781. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 52 52
Lines 3577 3587 +10
==========================================
+ Hits 3224 3234 +10
Misses 353 353
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mtfishman
marked this pull request as ready for review
September 27, 2026 22:24
mtfishman
enabled auto-merge (squash)
September 27, 2026 22:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HDF5 handles were left open until garbage collection, so repeated reads slowed down (https://itensor.discourse.group/t/2639). Now they are closed on return, and the ITensors and NDTensors compat floors are raised to the releases with the same fix for the per-tensor readers.