Drop runtime pkg_resources dependency for setuptools >= 82 compatibility - #102
Merged
Conversation
setuptools 82 removed the pkg_resources module entirely, which broke 'pacemaker' and pyace.multispecies_basisextension at import time (ModuleNotFoundError: No module named 'pkg_resources'). Replace pkg_resources.resource_filename with importlib.resources.files, keeping a pkg_resources fallback for Python 3.8 where importlib.resources.files is unavailable. Also drop the unused distutils.version.LooseVersion import from setup.py (distutils was removed from the stdlib in Python 3.12). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013rATYdnCXiGYC3bkbirURw
3 tasks
Bring in the CI fixes that landed after this branch was cut, so the pipeline can actually exercise the pkg_resources change. Both jobs on this PR (run 31264233541, 8 Aug) failed in "Test with python-ace with tensorpotential". The logs are not readable without admin rights, but the failure is pre-existing and not from this branch: the sibling PR ICAMS#103 (run 31264271622) failed in the same step on the same day off the same base, and 3bfa4df records that failure as pyace/activelearning.py:9: from maxvolpy.maxvol import maxvol E ModuleNotFoundError: No module named 'maxvolpy' Interrupted: 2 errors during collection i.e. no test ran at all. Master has since fixed it: * 3bfa4df installs lib/maxvolpy explicitly, because `pip install .` builds a wheel and never runs setup.py's InstallMaxVolPyLocalPackage hook, so the suite could not be collected at all. This branch's run predates that step existing in the workflow. * d63466f imports UnitCellFilter from ase.filters with a fallback to ase.constraints; that was the sole remaining failure once collection worked, and it only affected the 3.10 job. Merge is clean. Both sides touch bin/pacemaker in different hunks - the import block here, the cutoff deprecation from f366916 further down - and both survived intact. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools 82 removed the pkg_resources module entirely, which broke 'pacemaker' and pyace.multispecies_basisextension at import time (ModuleNotFoundError: No module named 'pkg_resources').
Replace pkg_resources.resource_filename with importlib.resources.files, keeping a pkg_resources fallback for Python 3.8 where importlib.resources.files is unavailable. Also drop the unused distutils.version.LooseVersion import from setup.py (distutils was removed from the stdlib in Python 3.12).
Description of Changes
Checklist
License Agreement
By submitting this pull request, I agree that:
Thank you for your contribution!