Repository navigation
root - chore: defense - stage npm publishes - #170
Conversation
The release job packs the package. pnpm stage publish sends the tarball to the staging queue. The checklist records pull request 169 as done. The checklist records the npm token check as done. Co-authored-by: Jared Wray <me@jaredwray.com>
The checklist names the open pull request. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request updates the DEFENSE_IN_DEPTH.md file to mark several security checklist items as completed or pending, specifically regarding workflow naming conventions, the verification of npm token secrets, and the status of the release workflow. No review comments were provided, so there is no feedback to address.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 639 639
Branches 151 146 -5
=========================================
Hits 639 639 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
This chore changes the release workflow only. No new test is required.
What kind of change does this PR introduce?
Chore. The release job packs the package and stages the tarball.
Summary
Section 5 switches the release publish step to
pnpm stage publish.The release job packs
@hyphen/sdkintopacked/.pnpm stage publishsends that tarball to the npm staging queue.The command is
pnpm stage publish ./packed/*.tgz --access public --provenance --no-git-checks.Status
DEFENSE_IN_DEPTH.md:name:and jobname:contain no spaces → PR root - chore: defense - use kebab-case workflow names #169.github/workflows/release.yamlpacks then stages withpnpm stage publish ./packed/*.tgz --no-git-checks→ (PR root - chore: defense - stage npm publishes #170 pending)These items stay open. Each one is manual:
Verification
release.yaml.pnpm pack --pack-destinationwrites a tarball that containsdist/.pnpm stage publish ./packed/*.tgz --access public --provenance --no-git-checks --dry-runaccepts the flags and skips the upload.Reference
defense-in-depth-nodejs § 5