ci: run refactor canary from main - #63
Closed
Hweinstock wants to merge 4 commits into
Closed
Hweinstock wants to merge 4 commits into
Hweinstock wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Scheduled and
workflow_runtriggers only fire on the default branch (docs), so aws#2503 and aws#2508 onrefactornever run.Solution
refactor-e2e.yml, always checking out refactor code.canary(refactor)with its own concurrency group.canary(refactor).refintoartifactRef/testRefso the canary runs the latest refactor tests against the@rcbuild.Notes
refactor-e2e.ymlavoids main's.github/workflows/e2e*path filter, which would otherwise trigger the full E2E suite on edits.canary-refactor, since main'sCanaryalready uses thecanarygroup.environment: matches refactor. Confirm the first run gets AWS credentials.WorkflowName=canary(refactor).Related Issue
Follow-up to aws#2503 and aws#2508.
Type of Change
Testing
Triggers can't run before merge. The test was a local simulation of the job: tests at
refactorHEAD, with the RC commit built inartifact/.Checklist