Translator.Culture should allow setting neutral language #89

Activity

1. JohanLarsson

   added a commit that references this issue on Jun 30, 2020

   Test for #89

   ...

   5a4ba20
2. JohanLarsson

   added

   needs-repro

   on Jun 30, 2020
3. JohanLarsson commented on Jun 30, 2020

   

   JohanLarsson

   on Jun 30, 2020

   Member

   More actions

   I failed to repro this bug using:

   <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
   
     <PropertyGroup>
       <OutputType>WinExe</OutputType>
       <TargetFramework>netcoreapp3.1</TargetFramework>
       <UseWPF>true</UseWPF>
       <NeutralLanguage>en</NeutralLanguage>
     </PropertyGroup>
   
     <ItemGroup>
       <ProjectReference Include="..\Gu.Localization\Gu.Localization.csproj" />
     </ItemGroup>
   
     <ItemGroup>
       <Compile Update="Properties\Resources.Designer.cs">
         <DesignTime>True</DesignTime>
         <AutoGen>True</AutoGen>
         <DependentUpon>Resources.resx</DependentUpon>
       </Compile>
   
       <EmbeddedResource Update="Properties\Resources.resx">
         <Generator>ResXFileCodeGenerator</Generator>
         <LastGenOutput>Resources.Designer.cs</LastGenOutput>
       </EmbeddedResource>
     </ItemGroup>
   
   </Project>

   public partial class MainWindow : Window
   {
       public MainWindow()
       {
           this.InitializeComponent();
           Translator.Culture = CultureInfo.GetCultureInfo("en");
       }
   }
4. JohanLarsson commented on Jul 1, 2020

   

   JohanLarsson

   on Jul 1, 2020

   Member

   More actions

   Published a new version https://www.nuget.org/packages/Gu.Localization/6.5.0 no intentional fix for this but we can check if it is still an issue.

   In a test project with no <NeutralLanguage>en</NeutralLanguage> I can see this being an issue as there is no mechanism for inheriting neutral culture in place.