Skip to content

Improve Analysis Queue tab accessibility - #949

Merged
elwills merged 2 commits into
masterfrom
analysisQueueAccessibility
Sep 11, 2026
Merged

Improve Analysis Queue tab accessibility#949
elwills merged 2 commits into
masterfrom
analysisQueueAccessibility

Conversation

@nbeatty-gpa

Copy link
Copy Markdown
Contributor

Change Enumeration and High colors to be more readable and use different line styles for the graph to improve accessibility.

@nbeatty-gpa
nbeatty-gpa force-pushed the analysisQueueAccessibility branch from 686235a to de3b3f4 Compare September 11, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Improves Analysis Queue graph accessibility through clearer colors and differentiated priority line styles.

Changes:

  • Updates Enumeration and High priority colors.
  • Adds distinct line styles and corrects Manual priority mapping.
  • Adds a terminal semicolon to AnalysisTaskTable export.
File summaries
File Description
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AppHost/FilesQueuedGraph.tsx Updated as part of this pull request.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AppHost/AnalysisTaskTable.tsx Updated as part of this pull request.
Review details

Suppressed comments (1)

Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AppHost/FilesQueuedGraph.tsx:142

  • The plot paths will use four distinct styles, but @gpa-gemstone/react-graph renders dash, short-dash, and long-dash identically in its legend. Consequently, the legend cannot communicate the new non-color distinction between Normal, High, and Manual Requeue, which leaves the accessibility improvement incomplete; update the graph legend to render each dash pattern or provide a custom legend for this plot.
                                    lineStyle={getPriorityLineStyle(a.Priority)}
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@elwills
elwills merged commit 48865fa into master Sep 11, 2026
4 checks passed
@elwills
elwills deleted the analysisQueueAccessibility branch September 11, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants