feat(pi): adopt telemetry conformance, agent-runtime eval, session fencing, daemon leases, diff renderer core - #226
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the approved Pi adoption plan (
docs/plans/pi-adoption-plan.md), landing the feasible items across hawk:P0
internal/observability/conformance): typed span/attribute schema + runner-independent conformance harness wired to the real span starters; schema-drift, sensitive-key, and passivity tests. CI now fails on telemetry schema drift.internal/feature/evalloop+hawk eval loop): drives the realengine.Sessiontool loop via an injectedChatClientin an isolated dir, snapshots the transcript, reports events/usage/cost. Runs in CI without external credentials via a mock client.P1
internal/session): additiveFencemetadata field persisted on save/load +FenceOf/SetFencehelpers.internal/daemon):POST/DELETE /v1/sessions/{id}/leaseacquire/release single-owner leases with fence enforcement; OpenAPI updated (parity test green).internal/tui/diff): line-granular diff + synchronized-output emission mirroring pi-tui, fully unit-tested. Full Bubble Tea renderer swap deferred to a runtime-verified follow-up.P2
Test plan
go test ./...green (twice + via pre-push hook)make vet,make lint,hawk verifygreenmarkdownlint-cli2clean on the updated plan doc