feat: animate skills registry operations with progress spinners - #285
Merged
Conversation
Add progress feedback to the network-backed skills commands, matching the doctor/preflight/update pattern: skills search, install, and trending now show a live spinner (or clean non-TTY lines). The --json path of skills search stays pure (spinner suppressed so stdout remains valid JSON).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The network-backed skills commands (
search,install,trending) performed registry fetches with no progress feedback. Wrapped them inCLIProgressspinners, matching the doctor/preflight/update pattern:skills search—Searching skill registryskills install—Installing skillskills trending—Fetching trending skillsOn a TTY each animates a live spinner; when stdout is piped/CI they emit one clean static line so output stays parseable.
The
skills search --jsonpath is guarded: the spinner is suppressed so stdout remains pure, valid JSON (verified:json.loadparses cleanly, 649 results).Verification
go build ./...,go vet ./cmd/,gofumpt -lclean.go test ./...exit 0 (full suite).skills search go: shows+ Searching skill registry (2.6s)thenSkills search complete in 2.6s, followed by results.skills search go --json: stdout is valid JSON (no spinner pollution).