Repository navigation
refactor(tool): migrate Glob/LS/Grep/Skill/Screenshot to typed schemas - #320
Merged
Merged
Conversation
Follow the established Schema()+Parameters() delegation pattern (single source of truth) with schema-parity tests locking the wire shape, and route Execute input parsing through DecodeInput[T]. Empty-input semantics preserved for LS/Skill (list modes). FuzzyFind excluded: its minimum/maximum constraints need a SchemaProperty extension first.
This was referenced Sep 15, 2026
Patel230
added a commit
that referenced
this pull request
Oct 2, 2026
#320) Follow the established Schema()+Parameters() delegation pattern (single source of truth) with schema-parity tests locking the wire shape, and route Execute input parsing through DecodeInput[T]. Empty-input semantics preserved for LS/Skill (list modes). FuzzyFind excluded: its minimum/maximum constraints need a SchemaProperty extension first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental slice of the tool-schema migration (the
Toolinterface itself stays unchanged for compatibility).Schema()+Parameters()delegation pattern (single source of truth, as withBashTool), with schema-parity tests locking each tool's wire shape.Executeinput parsing through the genericDecodeInput[T]; empty-input list semantics preserved for LS/Skill.minimum/maximumconstraints need aSchemaPropertyextension first (noted follow-up).Verified:
go vet ./...,golangci-linton the package (0 issues), fullgo test ./..., layer boundaries,testaudit.