Repository navigation
refactor(engine): drop the last re-export shim (safety) - #318
Merged
Merged
Conversation
Remove safety_reexports.go; internal and external callers now import internal/engine/safety directly (e.g. safety.PermissionRequest, safety.AutonomyLevel, safety.ParseAutonomyLevel). No engine re-export shims remain, so the engine namespace no longer flattens its sub-packages. Verified: go build ./..., go vet, golangci-lint (0 issues), full go test ./..., make boundaries.
Patel230
added a commit
that referenced
this pull request
Oct 2, 2026
Remove safety_reexports.go; internal and external callers now import internal/engine/safety directly (e.g. safety.PermissionRequest, safety.AutonomyLevel, safety.ParseAutonomyLevel). No engine re-export shims remain, so the engine namespace no longer flattens its sub-packages. Verified: go build ./..., go vet, golangci-lint (0 issues), full go test ./..., make boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
safety_reexports.go, the finalinternal/engine/*_reexports.goshim. Internal and external callers now importinternal/engine/safetydirectly (safety.PermissionRequest,safety.AutonomyLevel,safety.ParseAutonomyLevel, …).With this, no engine re-export shims remain — the
enginenamespace no longer flattens its sub-packages, so the true dependency graph is visible to the compiler and to readers.Verified:
go build ./...,go vet,golangci-lint(0 issues), fullgo test ./...,make boundaries.