Skip to content

refactor(engine): drop planning re-export shim #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patel230 merged 1 commit into from
Sep 15, 2026
Merged

refactor(engine): drop planning re-export shim #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 0 additions & 62 deletions internal/engine/planning_reexports.go
View file
Open in desktop

This file was deleted.

11 changes: 6 additions & 5 deletions internal/engine/tool_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"sync"

"github.com/GrayCodeAI/rho/internal/engine/diff"
"github.com/GrayCodeAI/rho/internal/engine/planning"
"github.com/GrayCodeAI/rho/internal/hooks"
"github.com/GrayCodeAI/rho/internal/intelligence/repomap"
"github.com/GrayCodeAI/rho/internal/observability/metrics"
Expand Down Expand Up @@ -317,20 +318,20 @@ func (s *ToolService) ExecuteAll(ctx context.Context, calls []types.ToolCall, ch
}
return results
}
plannedCalls := make([]PlannedCall, len(calls))
plannedCalls := make([]planning.PlannedCall, len(calls))
concurrentCalls := make([]indexedToolCall, 0, len(calls))
sequentialCalls := make([]indexedToolCall, 0, len(calls))
for i, call := range calls {
targets := s.ExtractTargets(call)
plannedCalls[i] = PlannedCall{ToolName: call.Name, Args: call.Arguments, Targets: targets}
plannedCalls[i] = planning.PlannedCall{ToolName: call.Name, Args: call.Arguments, Targets: targets}
item := indexedToolCall{index: i, tc: call}
if tool.IsReadOnly(call.Name) {
concurrentCalls = append(concurrentCalls, item)
} else {
sequentialCalls = append(sequentialCalls, item)
}
}
if report := EstimateBlastRadius(plannedCalls); report.Radius.NeedsConfirmation() && ch != nil {
if report := planning.EstimateBlastRadius(plannedCalls); report.Radius.NeedsConfirmation() && ch != nil {
emitEvent(ctx, ch, StreamEvent{Type: "blast_radius", Content: report.Message})
}

Expand Down Expand Up @@ -879,8 +880,8 @@ func (s *ToolService) ExtractTargets(tc types.ToolCall) []string {

// EstimateBlastRadius returns a blast-radius report for a set of
// planned tool calls. Drives the "needs confirmation" prompt.
func (s *ToolService) EstimateBlastRadius(planned []PlannedCall) *BlastRadiusReport {
return EstimateBlastRadius(planned)
func (s *ToolService) EstimateBlastRadius(planned []planning.PlannedCall) *planning.BlastRadiusReport {
return planning.EstimateBlastRadius(planned)
}

// ExecuteRegistered is the compatibility entry point for callers that still
Expand Down
Loading