Repository navigation
feat(auth): add service-to-service authentication sample - #1909
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a Ruby sample for service-to-service authentication using Cloud Functions, adding a Gemfile, a basic HTTP application, a helper to make authenticated GET requests, and integration tests. Feedback highlights critical issues in the implementation: the relay function in app.rb is hardcoded to return success instead of calling the target function, and the deployment script in service_auth_spec.rb uses the wrong entry point for the target function and fails to pass the target URL environment variable to the relay function. Additionally, improvements are recommended in service_auth.rb to validate the presence of the ID token and to configure connection and read timeouts on HTTP requests.
e49d2ae to
bf563f0
Compare
bf563f0 to
a4358ba
Compare
d91e7b7 to
e3d725f
Compare
e3d725f to
21b2c95
Compare
XrossFox
left a comment
There was a problem hiding this comment.
Not versed in ruby, but LG-enough-TM
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Description
Fixes Internal b/242962361
Checklist
bundle exec rubocop