Repository navigation
Fix video freeze on late-stream joins, real A/V sync - #2
Merged
Merged
Conversation
video render freeze still open; debug logging kept in on purpose
- Tighten the decode gap check from 1s (measured against the last keyframe) to 100ms (measured against the last decoded frame) - the old threshold let discontinuous frames reach the renderer, which is the likely cause of the canvas silently freezing after a mid-stream join - Pace audio decode/schedule off the video render clock instead of firing on arrival, so audio and video actually reflect the same position instead of audio racing ahead - Shorten engine GOP to ~2s (-g/-keyint_min) to bound late-joiner wait further, on top of the existing keyframe cache - Add dashboard test infra (vitest + testing-library), wire lint/test into CI - Strip debug instrumentation, remove leftover FPS overlay from ParticleBackground
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-r <fps>) in the ffmpeg transcode — source was silently 25fps while pacing assumed 30fps, playing back ~20% too fast