Feature/clear readmes - #9
Conversation
no dependencies on wsl
made repo debian based, not wsl dependent
Fix/source debugging works
make repo independent of chuck norise module
download the kernel source and match symbols for debugger to show source
Feature/cleanup repo
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cd0008a4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tarballs=("$usr_src_dir"/linux-source-*.tar.* "$usr_src_dir"/linux-source-*/linux-source-*.tar.*) | ||
| shopt -u nullglob | ||
| if [[ ${#tarballs[@]} -gt 0 ]]; then | ||
| tarball="${tarballs[0]}" | ||
| if is_kernel_source_root "$source_tree"; then |
There was a problem hiding this comment.
When no pre-extracted source tree is found, this path unconditionally uses tarballs[0], which is glob/lexicographic order, not the running kernel version. On hosts where multiple linux-source-*.tar.* files exist (common after kernel upgrades), this can extract the wrong kernel source and make GDB source mapping point to mismatched files, causing incorrect stepping/breakpoints in kernel code.
Useful? React with 👍 / 👎.
| tar -C "$source_tree" --strip-components=1 -xf "$tarball" | ||
| fi | ||
| ln -s source-tree "$source_link" | ||
| echo " kernel source: $source_link -> source-tree" |
There was a problem hiding this comment.
The extraction always uses --strip-components=1 and then immediately links source to source-tree without validating that a kernel root was actually produced. If the tarball layout does not include a single top-level directory, strip-components=1 can drop top-level files and leave an incomplete tree, yet the script reports success and later debugging fails with missing kernel sources.
Useful? React with 👍 / 👎.
1 participant
No description provided.