Update readme, fix previous mistakes, add viewBox to generated svgs. - #213
Open
CallumNZ wants to merge 4 commits into
Open
Update readme, fix previous mistakes, add viewBox to generated svgs.#213CallumNZ wants to merge 4 commits into
CallumNZ wants to merge 4 commits into
Conversation
CallumNZ
force-pushed
the
generate14Sep26
branch
from
September 14, 2026 00:27
ccf16a8 to
7513fc6
Compare
To allow CSS to resize them without clipping
CallumNZ
force-pushed
the
generate14Sep26
branch
from
September 14, 2026 04:07
917da67 to
3d5f949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This update was initiated simply to add the
viewBoxattribute to the generated SVGs, so that they can be resized by downstream users. Other changes were made to hopefully reduce confusion the next time someone edits this package, and needs to regenerate the SVGs.Production Changes
The following production changes are required to deploy these changes:
Review
Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.
Code Review Guide
Insert check list here if needed.