Skip to content

Update readme, fix previous mistakes, add viewBox to generated svgs. - #213

Open
CallumNZ wants to merge 4 commits into
mainfrom
generate14Sep26
Open

Update readme, fix previous mistakes, add viewBox to generated svgs.#213
CallumNZ wants to merge 4 commits into
mainfrom
generate14Sep26

Conversation

@CallumNZ

Copy link
Copy Markdown
Contributor

Proposed Changes

This update was initiated simply to add the viewBox attribute to the generated SVGs, so that they can be resized by downstream users. Other changes were made to hopefully reduce confusion the next time someone edits this package, and needs to regenerate the SVGs.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant