Figure.sac: Plot seismograms in SAC format - #4854
Open
Chuan1937 wants to merge 29 commits into
Open
Conversation
Chuan1937
changed the title
20 tasks
seisman
reviewed
Aug 24, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Aug 26, 2026
seisman
reviewed
Sep 4, 2026
seisman
reviewed
Sep 7, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Sep 7, 2026
seisman
reviewed
Sep 7, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Sep 7, 2026
seisman
reviewed
Sep 7, 2026
seisman
reviewed
Sep 8, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Sep 8, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Sep 8, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Sep 8, 2026
Comment on lines
+189
to
+201
| preprocess_value = None | ||
| if preprocess: | ||
| preprocess_values: list[str] = [] | ||
| for operation in preprocess: | ||
| value = Alias( | ||
| operation, | ||
| name="preprocess", | ||
| mapping={"integral": "i", "square": "q", "demean": "r"}, | ||
| )._value | ||
| if not isinstance(value, str): | ||
| raise GMTValueError(value, description="preprocess operation") | ||
| preprocess_values.append(value) | ||
| preprocess_value = "".join(preprocess_values) |
Member
There was a problem hiding this comment.
Please move this code block into a private function _alias_option_F and add some doctests for it. You can use subplot.py as a reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request wraps the module
sac.Preview at https://pygmt-dev--4854.org.readthedocs.build/en/4854/api/generated/pygmt.Figure.sac.html
Related to #4853.