Repository navigation
Update player motion to be impulse-based - #1322
Merged
Merged
Conversation
misode
changed the title
misode
added
the
quality-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR swaps the existing player motion library with one that uses the impulse enchantment. Tested and still works for the one use case we currently have: Dashing pneuma from OoA.
Also fixes a bug that checked the
lib_lore_minorversion instead of thelib_player_motion_minor(which never appeared as an issue due to OoA requiring metallurgy which includes lib_lore).Relies on #1321.