Skip to content

Add missing changeset and update Nx/Node versions - #596

Draft
ancheetah wants to merge 3 commits into
developfrom
aj-ci-updates
Draft

ancheetah wants to merge 3 commits into
developfrom
aj-ci-updates

Conversation

@ancheetah

@ancheetah ancheetah commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

JIRA Ticket

Description

@changeset-bot

changeset-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0a2a431

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@forgerock/token-vault Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the root label Oct 14, 2026
@nx-cloud

nx-cloud Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 925994c

Command Status Duration Result
nx affected -t build lint test docs e2e-ci ❌ Failed 55s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 4s View ↗

💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.


☁️ Nx Cloud last updated this comment at 2026-10-14 14:52:52 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/javascript-sdk@596
pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/ping-protect@596
pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/token-vault@596

commit: e3eef3b

nx-cloud[bot]

This comment was marked as outdated.

@nx-cloud nx-cloud Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We fixed the failing javascript-sdk:test run by running device.store.test.ts in the node vitest environment. After the Node 24 upgrade, native fetch rejects the jsdom AbortSignal that RTK Query passes to it, which caused the "RequestInit: Expected signal" errors. Under node, both come from the same realm, so the requests succeed. Locally, pnpm nx test javascript-sdk now passes.

Tip

✅ We verified this fix by re-running javascript-sdk:test.

diff --git a/packages/javascript-sdk/src/device-client/device.store.test.ts b/packages/javascript-sdk/src/device-client/device.store.test.ts
index 897e45b..c60d2a2 100644
--- a/packages/javascript-sdk/src/device-client/device.store.test.ts
+++ b/packages/javascript-sdk/src/device-client/device.store.test.ts
@@ -1,3 +1,4 @@
+// @vitest-environment node
 /*
  * @forgerock/javascript-sdk
  *
diff --git a/packages/javascript-sdk/vitest.setup.ts b/packages/javascript-sdk/vitest.setup.ts
index 644736e..b90f600 100644
--- a/packages/javascript-sdk/vitest.setup.ts
+++ b/packages/javascript-sdk/vitest.setup.ts
@@ -1 +1,4 @@
-import 'vitest-canvas-mock';
+// Tests that opt into the node environment (e.g. for native fetch) have no window to mock
+if (typeof window !== 'undefined') {
+  await import('vitest-canvas-mock');
+}

Apply fix via Nx Cloud  Reject fix via Nx Cloud


Or Apply changes locally with:

npx nx-cloud apply-locally iq1g-J99C

Apply fix locally with your editor ↗   View interactive diff ↗



🎓 Learn more about Self-Healing CI on nx.dev

@ancheetah ancheetah changed the title Add missing changeset and update Node version Add missing changeset and update Nx/Node versions Oct 14, 2026
@ancheetah
ancheetah marked this pull request as draft October 14, 2026 15:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant