Repository navigation
feat(generator): support versioned_files on package definitions - #253
Merged
Merged
Conversation
There was a problem hiding this comment.
No blocking findings. The write loop follows the existing hook pattern. Traversal is validated with the shared has_traversal. Files are written before chore: initial setup, so they land in that commit, and the integration test checks this. The schema, README and serde types agree.
Nit: a versioned_files entry whose path is version.toml (or <pkg.path>/version.toml) silently replaces the generated default, which contradicts "the default version.toml is still generated" in the README. Either document that it overrides the default, or reject that path in validate.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #224
Adds an optional
versioned_fileslist to packages, in the shape consumers already write. Entries withcontentare written relative to the repo root before the initial commit;formatis informational. The defaultversion.tomlis unchanged, paths get the same traversal check as hooks, and the JSON schema and README are updated. Additive, existing definitions generate the same output.Not done: warning on unknown keys under
packages[](the related idea in the issue).