Repository navigation
Conversation
Contributor
Author
|
Question: should |
There was a problem hiding this comment.
Nothing blocking. The size lookup is wrapped like the benchmark embed, so a failing gh call can't abort postBump mid-release. The string toFixed(1) value matches the existing *_size_mb fields. gh release view with no tag skips drafts, so the --draft release this run creates won't be picked up. Also, GH_TOKEN isn't one of the token variables ferrflow reads, so it won't override the bot token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1045
embed-release-data.jsnow writesferrflow_release_size_mbintodocs/site/data/benchmarks.json, taken from theferrflow-linux-x64.tar.gzasset of the latest published release (the one before the release in progress). The release step in CI getsGH_TOKENsogh release viewcan read it. Ifghfails or the asset is missing, the script logs it and leaves the file as is, so a release is never aborted by it.Checked locally with a stubbed
gh(value written, 3.4 for a 3.4 MB tarball) and a failinggh(file untouched). The repo has no JS test setup, so no test file was added.Open question: should
ferrflow_binary_size_mbstay as a fallback in the consumers (landing.component.ts/sync-docs.mjs)? That lives in FerrFlow-Cloud, so I did not touch it here. Auto-merge is off for that reason, and because the release job path can only be exercised on a real release.