Fix for Call to 'System.IO.Path.Combine' may silently drop its earlier arguments - #2
Merged
Merged
Conversation
…r arguments Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Alcheri <barry.suridge@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses a CodeQL warning about System.IO.Path.Combine potentially discarding earlier segments when a later segment is rooted, by switching the settings file path construction to Path.Join, which does not have the rooted-segment reset behavior.
Changes:
- Replace
Path.Combine(...)withPath.Join(...)for theSettingsPathstatic initializer in the C# greeter plugin.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a combination approach that cannot be reset by a rooted later segment. The best fix is to normalize the base directory first and then append the filename with
Path.Joininstead ofPath.Combine.Path.Joinconcatenates path segments without the rooted-path reset behavior ofPath.Combine, which directly addresses the CodeQL concern while preserving current functionality (<base>/settings.json).In
example.csharp.greeter/GreeterPlugin.cs, replace the staticSettingsPathinitializer (lines 8–10 in the snippet) so it usesPath.Join(...)with the same base-directory expression and"settings.json". No new imports, methods, or dependencies are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.