Skip to content

Fix for Missed opportunity to use Where #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alcheri merged 1 commit into from
Aug 11, 2026
Merged

Fix for Missed opportunity to use Where #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions example.csharp.greeter/GreeterPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Linq;
using System.Reflection;
using System.Text.Json;
Comment on lines +1 to 3
using Fabulor.Plugins;
Expand Down Expand Up @@ -121,13 +122,11 @@ private void LoadTargets()
try
{
var settings = JsonSerializer.Deserialize<GreeterSettings>(File.ReadAllText(SettingsPath));
foreach (var target in settings?.Targets ?? [])
foreach (var target in (settings?.Targets ?? [])
.Where(target => !string.IsNullOrWhiteSpace(target.Network)
&& !string.IsNullOrWhiteSpace(target.Channel)))
{
if (!string.IsNullOrWhiteSpace(target.Network)
&& !string.IsNullOrWhiteSpace(target.Channel))
{
_targets[TargetKey(target.Network, target.Channel)] = target;
}
_targets[TargetKey(target.Network, target.Channel)] = target;
}
}
catch (Exception error) when (error is IOException or JsonException or UnauthorizedAccessException)
Expand Down