Skip to content

Error Checking/Reporting When Fetching F/W Signatures - #595

Merged
ExtremeFiretop merged 1 commit into
ExtremeFiretop:devfrom
Martinski4GitHub:dev
Sep 3, 2026
Merged

ExtremeFiretop merged 1 commit into
ExtremeFiretop:devfrom
Martinski4GitHub:dev

Conversation

@Martinski4GitHub

@Martinski4GitHub Martinski4GitHub commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator
  • Improved error checking and reporting when downloading F/W image signatures from RMerlin's website. This allows users to see when the failure to download the checksum signatures may be due to their IP address currently being banned from accessing the website server [HTTP error code 403].

  • Miscellaneous improvements.

Sample check and report of HTTP error:

CurlErrorChecking Reporting

- Improved error checking and reporting when downloading F/W image signatures from RMerlin's website. This allows users to see when the failure to download the checksum signatures may be due to their IP address being currently banned from accessing the website server [HTTP error code 403].

- Miscellaneous improvements.
@ExtremeFiretop
ExtremeFiretop merged commit 255512f into ExtremeFiretop:dev Sep 3, 2026
2 checks passed
@ExtremeFiretop

Copy link
Copy Markdown
Owner

Merged, approved all looking good!

@Martinski4GitHub

Copy link
Copy Markdown
Collaborator Author

@ExtremeFiretop,

Whenever you get a chance, please review and test the changes in this PR.
As I mentioned, the idea is to explicitly check and report error codes from the curl command, including HTTP error codes.
This way, users can become aware in cases when their IP address has been banned from accessing RMerlin's website.

Talk to you later this evening or tomorrow evening.

@ExtremeFiretop

Copy link
Copy Markdown
Owner

@ExtremeFiretop,

Whenever you get a chance, please review and test the changes in this PR. As I mentioned, the idea is to explicitly check and report error codes from the curl command, including HTTP error codes. This way, users can become aware in cases when their IP address has been banned from accessing RMerlin's website.

Talk to you later this evening or tomorrow evening.

I was doing it live as you were typing that clearly ! 🤣
I was on it as soon as you submitted it !

@Martinski4GitHub

Copy link
Copy Markdown
Collaborator Author

Merged, approved all looking good!

That was FAST!!!! LOL!!
I'm going offline right now to do some work (WFH) for my day job.

I'll be doing some more testing and validation later this evening, just in case I missed something.
Also, I'll run the latest code through the Linter tool.

Take care, bud!!

@Martinski4GitHub

Copy link
Copy Markdown
Collaborator Author

@ExtremeFiretop,

I ran a few more tests using the latest code in the develop branch, and so far it's working well.
The Linter tool didn't report any errors or new warnings - we have good "clean" code!!!

When/If you get feedback from the OP (@Razor221) confirming that the latest code addresses the issue they reported, feel free to release the next production version. At this point, I have nothing else to add or modify.

Over the weekend, I'll take a look at your YazFi PR.

Have a good one, bud!!

@ExtremeFiretop

Copy link
Copy Markdown
Owner

@ExtremeFiretop,

I ran a few more tests using the latest code in the develop branch, and so far it's working well. The Linter tool didn't report any errors or new warnings - we have good "clean" code!!!

When/If you get feedback from the OP (@Razor221) confirming that the latest code addresses the issue they reported, feel free to release the next production version. At this point, I have nothing else to add or modify.

Over the weekend, I'll take a look at your YazFi PR.

Have a good one, bud!!

I'm sending it out even without the formal agreement we discussed in SNBforums.
I'll just use your previous message as a form of agreement ;)

Thanks for your review buddy! I much prefer your wording on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants