Skip to content

Vendor NSpark (Elenpay fork) and build the image from the repository root - #16

Draft
Jossec101 wants to merge 4 commits into
developfrom
spark/nspark-submodule
Draft

Jossec101 wants to merge 4 commits into
developfrom
spark/nspark-submodule

Conversation

@Jossec101

@Jossec101 Jossec101 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
  • Adds tests that lock today's PSBT signatures byte for byte, before anything changes.
  • Adds NSpark (Elenpay fork) as a git submodule and updates NBitcoin.
  • Builds the Docker image from the repo root; CI and the justfile follow.
  • No behavior change.

Stack created with GitHub Stacks CLI • Give Feedback 💬

Signatures are deterministic (RFC 6979), so the six existing signing vectors
get golden outputs recorded with NBitcoin 10.0.9. Any later bump or refactor
must reproduce them exactly. Tests that set MF_ env vars share one xUnit
collection so they don't race.
- vendor/nspark: Elenpay fork of NSpark (native libspark_frost rebuilt from
  Lightspark source, NSpark.RemoteSigner contract) as a git submodule.
- RemoteSigner references NSpark.RemoteSigner; NBitcoin 10.0.9 -> 10.0.10
  (NSpark's minimum). The golden PSBT outputs are unchanged.
- Dockerfile builds from the repo root (docker build -f RemoteSigner/Dockerfile .),
  with a root .dockerignore; justfile, lambda tools defaults and CI follow.
- CI checks out the submodule.

No behavior change: nothing calls into NSpark yet.
The NSpark changes go as pull requests straight to orklabs/nspark, so
vendor/nspark points there. The submodule pins the head of that stack
until it merges upstream.
The NSpark changes this signer needs, the RemoteSigner contract among
them, are PRs on the Elenpay fork. Pin its stack top until they reach
a fork tag.
@Jossec101
Jossec101 added this pull request to stack #21 October 9, 2026 23:23
@Jossec101 Jossec101 changed the title spark/nspark submodule Vendor NSpark (Elenpay fork) and build the image from the repository root Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant