feat: report basis dimension alongside LU fill and density - #2007
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lpLuMaxDim, the basis dimension at whichlpLuMaxDensitywas last observed, alongside the existinglpLuMaxFill/lpLuMaxDensityLP stats. Density alone hides whether a dense basis was tiny or large.RevisedSimplex.maxLuDim->FloatLpResult.luMaxDim->ComponentLpSolver->LpBounding.observeLuFill->LpStats/LpStatsSink, and is printed byCliStats(-s) the same way the other two already are.LpStats.luMaxDim), independent ofluMaxDensity— a single running max can't also report the dimension at which the density max occurred across a whole search, so size and density are separate signals rather than a pinned pair.Why
Motivated by #2006: before building a dense-basis LU fallback, we need to know whether the corpus ever produces small-and-still-hard bases (many repeated factorizations, unresolved search) versus large-and-sparse ones. Run over real MIPLIB2017/MiniZinc/XCSP3 samples, this already found the motivating shape (
gr4x6: dimension 34, 10,340 solves, unproved) and confirmed large bases stay sparse regardless of difficulty (nag: dimension 5,796, 0.02% density).Test plan
./gradlew check lintDocs:klause:updateKotlinAbirun to reflect the new publicLpStats.luMaxDimfieldklause-cli -sandklause-bench solveagainst real MIPLIB2017/mzn-bench/xcsp3-cop samples