Repository navigation
Return None from get_meals() when the school doesn't use meals - #130
Merged
ivanhrabcak merged 2 commits intoOct 11, 2026
Merged
Conversation
The menu page of a school without EduPage's meal module has no edupageData, so get_meals() failed with IndexError. Co-Authored-By: Claude Code
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For a school that doesn't use EduPage's meal module,
get_meals()fails with:The
/menu/page of such a school has noedupageData:at all.Fix
Return
Nonewhen the page has noedupageData:. That matches whatget_meals()already returns for empty menu data (#121).Tests
New case in
tests/test_lunches.pyfor a page withoutedupageData. It fails onmaster, and the suite passes. Also checked against a real school without meals:get_meals()returnsNone.Co-Authored-By: Claude Code